From 3e106351937ccec86db5bdde63d359b544868527 Mon Sep 17 00:00:00 2001 From: Wei Liu Date: Mon, 18 Sep 2017 14:56:12 +0100 Subject: [PATCH] libxl: use libxl__read_xenstore_mandatory in vtpm function libxl__read_xenstore can return NULL. Use the _mandatory variant to return early when the read fails. Coverity-ID: 1418098 Signed-off-by: Wei Liu Acked-by: Ian Jackson --- tools/libxl/libxl_vtpm.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_vtpm.c b/tools/libxl/libxl_vtpm.c index 21320870d4..6182cfc49c 100644 --- a/tools/libxl/libxl_vtpm.c +++ b/tools/libxl/libxl_vtpm.c @@ -79,12 +79,15 @@ static int libxl__vtpm_from_xenstore(libxl__gc *gc, const char *libxl_path, libxl_device_vtpm *vtpm) { int rc; - char *be_path; + const char *be_path; char *uuid; vtpm->devid = devid; - be_path = libxl__xs_read(gc, XBT_NULL, GCSPRINTF("%s/backend", libxl_path)); + rc = libxl__xs_read_mandatory(gc, XBT_NULL, + GCSPRINTF("%s/backend", libxl_path), + &be_path); + if (rc) return rc; rc = libxl__backendpath_parse_domid(gc, be_path, &vtpm->backend_domid); if (rc) return rc; -- 2.30.2